Skip to content

Conversation

@martin-helmich
Copy link
Member

Fixes #1275

@martin-helmich martin-helmich requested a review from Copilot August 19, 2025 08:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the "container run" command by implementing more flexible argument parsing and command construction. The changes address issue #1275 by allowing the command to handle variadic arguments more dynamically while maintaining proper command structure.

  • Disabled strict argument parsing to allow for more flexible command and argument handling
  • Implemented dynamic command construction that properly parses variadic arguments from the command line
  • Updated command usage documentation to reflect the new flexible argument structure

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
src/commands/container/run.tsx Implements relaxed argument strictness, custom usage string, and dynamic command building logic
docs/container.md Updates documentation to reflect the new command usage pattern with proper argument descriptions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@martin-helmich martin-helmich merged commit 8a811c5 into master Aug 19, 2025
11 checks passed
@martin-helmich martin-helmich deleted the fix/container-run-args branch August 19, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"container run" command silently drops additional args after the command

2 participants