Skip to content

feat(stack): warn about container deletion during stack deploy#1755

Merged
martin-helmich merged 4 commits intomasterfrom
feat/stack-deploy-deletion-warning
Apr 13, 2026
Merged

feat(stack): warn about container deletion during stack deploy#1755
martin-helmich merged 4 commits intomasterfrom
feat/stack-deploy-deletion-warning

Conversation

@martin-helmich
Copy link
Copy Markdown
Member

Summary

  • Add warning when mw stack deploy would delete existing containers not in the new stack definition
  • Prompt for interactive confirmation in TTY mode before proceeding with deletion
  • Add --force flag to skip confirmation prompt
  • Refactor exec function into smaller, focused methods for better readability

Closes #1400

🤖 Generated with Claude Code

martin-helmich and others added 4 commits April 10, 2026 14:37
Add warning and confirmation prompt when deploying a stack would delete
existing containers that are not in the new stack definition. Users are
now notified which containers will be removed and asked to confirm in
interactive mode. A --force flag allows skipping the confirmation.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Break down the exec function into smaller, focused methods:
- getExistingStack: retrieve current stack state
- confirmDeletion: handle deletion confirmation flow
- deployStack: deploy the stack definition
- recreateServices: recreate services requiring recreation

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@martin-helmich martin-helmich force-pushed the feat/stack-deploy-deletion-warning branch from 5c18ce8 to c0248c8 Compare April 13, 2026 09:07
@martin-helmich martin-helmich marked this pull request as ready for review April 13, 2026 09:07
@martin-helmich martin-helmich requested a review from gandie April 13, 2026 09:13
Copy link
Copy Markdown
Contributor

@gandie gandie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martin-helmich martin-helmich merged commit 8e3e6e6 into master Apr 13, 2026
12 checks passed
@martin-helmich martin-helmich deleted the feat/stack-deploy-deletion-warning branch April 13, 2026 10:39
mittwald-machine added a commit that referenced this pull request Apr 13, 2026
# [1.15.0](v1.14.0...v1.15.0) (2026-04-13)

### Features

* **stack:** warn about container deletion during stack deploy ([#1755](#1755)) ([8e3e6e6](8e3e6e6)), closes [#1400](#1400)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mw stack deploy should warn if items would be overwritten

2 participants