Replies: 2 comments
|
Hi, I’ve reworked the implementation based on the issue identified in #343 and the requirements in #358.
|
0 replies
|
Completed in v5.0.6: Japanese connector-verification progress and successful Doctor checks are localized, with Chinese equivalents as well. Literal connector names/endpoints and original unknown/error messages are preserved. Thanks @cXSHoz for the contribution in #400. Closing this as resolved. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Preserving the useful localization idea from declined PR #343: show Japanese connector-verification progress and successful Doctor diagnostics in the Japanese launcher UI.
The submitted localizer has a reproduced defect: a connector named
Native $&is displayed asNative {name}. It passes the name as a String.replace replacement string, which interprets replacement tokens. This also changes English and Chinese output even though those languages were intended to remain unchanged. The failure was reproduced by executing the PR function, not inferred from a screenshot.A future implementation should localize the intended UI messages while preserving dynamic connector names and endpoints literally, retain original unknown/error messages, and leave backend/CLI diagnostics unchanged. Cover ordinary names and replacement-token/quote/backslash characters. This is a backlog enhancement, separate from the P1 stabilization work; another PR is not automatically accepted or reserved to the original implementation.
All reactions