chore/add external id#254
Conversation
| *, | ||
| store_identifier: str, | ||
| metadata: Optional[object] | NotGiven = not_given, | ||
| config: file_create_params.Config | Omit = omit, |
There was a problem hiding this comment.
Bug: Type Mismatch: Metadata Omission in Create Flow
Type inconsistency for metadata parameter in create_and_poll method. The create() method expects metadata: object | Omit = omit, but create_and_poll() declares it as metadata: Optional[object] | NotGiven = not_given. When create_and_poll passes metadata to create(), there's a type mismatch between NotGiven and Omit, which could cause the metadata to not be properly omitted from the request.
| *, | ||
| store_identifier: str, | ||
| metadata: Optional[object] | NotGiven = not_given, | ||
| config: file_create_params.Config | Omit = omit, |
There was a problem hiding this comment.
Bug: Async metadata type mismatch in poller method
Type inconsistency for metadata parameter in async create_and_poll method. The async create() method expects metadata: object | Omit = omit, but async create_and_poll() declares it as metadata: Optional[object] | NotGiven = not_given. When create_and_poll passes metadata to create(), there's a type mismatch between NotGiven and Omit, which could cause the metadata to not be properly omitted from the request.
feat(api): update via SDK Studio
feat(api): api update
codegen metadata
chore(internal): grammar fix (it's -> its)
chore: add the external id and parsing strategy
Note
Extends store file operations to accept external_id with new config/overwrite options and updates polling to use a unified file_identifier, plus minor docs/metadata tweaks.
poll()now takesfile_identifier(ID orexternal_id) and updates internal calls accordingly in both sync/async resources.config,external_id, andoverwriteparameters tocreate_and_poll(),upload(), andupload_and_poll()(sync and async), plumbed through tocreate._utils.pycomment ("it's" → "its")..stats.ymlconfig_hash.Written by Cursor Bugbot for commit 31187b0. This will update automatically on new commits. Configure here.