Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates plugin entrypoint class names across the MixerApi plugin suite to address CakePHP 5.3 deprecation warnings and aligns CI to test newer runtime/framework ranges.
Changes:
- Rename plugin entry classes from generic
Pluginto<PluginName>Plugin(e.g.,HalViewPlugin,JwtAuthPlugin,MixerApiPlugin) and update the MixerApi plugin test accordingly. - Update PR workflow PHP matrix (8.4 → 8.5) and broaden CakePHP compatibility testing to cover the full
^5.0range.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| plugins/mixerapi/tests/TestCase/PluginTest.php | Updates the test to instantiate MixerApiPlugin instead of Plugin. |
| plugins/mixerapi/src/MixerApiPlugin.php | Renames plugin entry class to MixerApiPlugin. |
| plugins/jwt-auth/src/JwtAuthPlugin.php | Renames plugin entry class to JwtAuthPlugin. |
| plugins/json-ld-view/src/JsonLdViewPlugin.php | Renames plugin entry class to JsonLdViewPlugin. |
| plugins/hal-view/src/HalViewPlugin.php | Renames plugin entry class to HalViewPlugin. |
| plugins/exception-render/src/ExceptionRenderPlugin.php | Renames plugin entry class to ExceptionRenderPlugin. |
| plugins/crud/src/CrudPlugin.php | Renames plugin entry class to CrudPlugin. |
| plugins/collection-view/src/CollectionViewPlugin.php | Renames plugin entry class to CollectionViewPlugin. |
| plugins/bake/src/BakePlugin.php | Renames plugin entry class to BakePlugin. |
| .github/workflows/pull-request.yml | Updates CI matrices for PHP and CakePHP version coverage. |
Comments suppressed due to low confidence (8)
plugins/mixerapi/src/MixerApiPlugin.php:16
- Renaming the plugin entry class from
PlugintoMixerApiPluginis a backwards-incompatible public API change for any consumers instantiatingMixerApi\Plugindirectly. Consider adding a small deprecated shim (e.g., aMixerApi\Pluginclass insrc/Plugin.phpthat extendsMixerApiPlugin, or aclass_alias) so existing integrations keep working while addressing the CakePHP 5.3 deprecation.
plugins/json-ld-view/src/JsonLdViewPlugin.php:12 - Renaming the plugin class from
PlugintoJsonLdViewPlugincan break downstream code that still refers toMixerApi\\JsonLdView\\Plugin. Consider providing a deprecatedPluginshim (orclass_alias) for a transition period if this package is consumed outside this repo.
plugins/hal-view/src/HalViewPlugin.php:11 - Renaming the plugin entry class from
PlugintoHalViewPluginis a BC break for consumers referencingMixerApi\\HalView\\Plugin. If backwards compatibility matters, add a deprecatedPluginshim class (orclass_alias) to keep the old FQCN working while transitioning.
plugins/exception-render/src/ExceptionRenderPlugin.php:11 - Changing the plugin entry class name from
PlugintoExceptionRenderPluginis a backwards-incompatible change for code that importsMixerApi\\ExceptionRender\\Plugin. Consider adding a deprecatedPluginshim (orclass_alias) to preserve compatibility for external consumers.
plugins/collection-view/src/CollectionViewPlugin.php:12 - Renaming the plugin entry class from
PlugintoCollectionViewPluginis a backwards-incompatible change for external code usingMixerApi\\CollectionView\\Plugin. Consider adding a deprecatedPluginshim (orclass_alias) to keep the old FQCN working for a transition period.
plugins/jwt-auth/src/JwtAuthPlugin.php:13 - Renaming this class from
PlugintoJwtAuthPluginis a backwards-incompatible change for any external code referencingMixerApi\\JwtAuth\\Plugin. If you need to preserve BC, consider adding a deprecatedPluginshim class (orclass_alias) so existing consumers don’t break.
plugins/crud/src/CrudPlugin.php:20 - Renaming the plugin entry class from
PlugintoCrudPluginis a BC break for any consumers referencingMixerApi\\Crud\\Plugin. If this plugin is published/consumed externally, consider adding a deprecatedPluginshim class (orclass_alias) to maintain compatibility during the transition.
plugins/bake/src/BakePlugin.php:14 - Renaming the plugin entry class from
PlugintoBakePluginis a BC break for consumers that still referenceMixerApi\\Bake\\Plugin. If backwards compatibility is a goal, consider adding a deprecatedPluginshim class (orclass_alias) to preserve the old FQCN while transitioning.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.