Skip to content

Handle cakephp 5.3 deprecations#160

Open
cnizzardini wants to merge 1 commit intomasterfrom
cakephp5.3-deprecations
Open

Handle cakephp 5.3 deprecations#160
cnizzardini wants to merge 1 commit intomasterfrom
cakephp5.3-deprecations

Conversation

@cnizzardini
Copy link
Member

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates plugin entrypoint class names across the MixerApi plugin suite to address CakePHP 5.3 deprecation warnings and aligns CI to test newer runtime/framework ranges.

Changes:

  • Rename plugin entry classes from generic Plugin to <PluginName>Plugin (e.g., HalViewPlugin, JwtAuthPlugin, MixerApiPlugin) and update the MixerApi plugin test accordingly.
  • Update PR workflow PHP matrix (8.4 → 8.5) and broaden CakePHP compatibility testing to cover the full ^5.0 range.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
plugins/mixerapi/tests/TestCase/PluginTest.php Updates the test to instantiate MixerApiPlugin instead of Plugin.
plugins/mixerapi/src/MixerApiPlugin.php Renames plugin entry class to MixerApiPlugin.
plugins/jwt-auth/src/JwtAuthPlugin.php Renames plugin entry class to JwtAuthPlugin.
plugins/json-ld-view/src/JsonLdViewPlugin.php Renames plugin entry class to JsonLdViewPlugin.
plugins/hal-view/src/HalViewPlugin.php Renames plugin entry class to HalViewPlugin.
plugins/exception-render/src/ExceptionRenderPlugin.php Renames plugin entry class to ExceptionRenderPlugin.
plugins/crud/src/CrudPlugin.php Renames plugin entry class to CrudPlugin.
plugins/collection-view/src/CollectionViewPlugin.php Renames plugin entry class to CollectionViewPlugin.
plugins/bake/src/BakePlugin.php Renames plugin entry class to BakePlugin.
.github/workflows/pull-request.yml Updates CI matrices for PHP and CakePHP version coverage.
Comments suppressed due to low confidence (8)

plugins/mixerapi/src/MixerApiPlugin.php:16

  • Renaming the plugin entry class from Plugin to MixerApiPlugin is a backwards-incompatible public API change for any consumers instantiating MixerApi\Plugin directly. Consider adding a small deprecated shim (e.g., a MixerApi\Plugin class in src/Plugin.php that extends MixerApiPlugin, or a class_alias) so existing integrations keep working while addressing the CakePHP 5.3 deprecation.
    plugins/json-ld-view/src/JsonLdViewPlugin.php:12
  • Renaming the plugin class from Plugin to JsonLdViewPlugin can break downstream code that still refers to MixerApi\\JsonLdView\\Plugin. Consider providing a deprecated Plugin shim (or class_alias) for a transition period if this package is consumed outside this repo.
    plugins/hal-view/src/HalViewPlugin.php:11
  • Renaming the plugin entry class from Plugin to HalViewPlugin is a BC break for consumers referencing MixerApi\\HalView\\Plugin. If backwards compatibility matters, add a deprecated Plugin shim class (or class_alias) to keep the old FQCN working while transitioning.
    plugins/exception-render/src/ExceptionRenderPlugin.php:11
  • Changing the plugin entry class name from Plugin to ExceptionRenderPlugin is a backwards-incompatible change for code that imports MixerApi\\ExceptionRender\\Plugin. Consider adding a deprecated Plugin shim (or class_alias) to preserve compatibility for external consumers.
    plugins/collection-view/src/CollectionViewPlugin.php:12
  • Renaming the plugin entry class from Plugin to CollectionViewPlugin is a backwards-incompatible change for external code using MixerApi\\CollectionView\\Plugin. Consider adding a deprecated Plugin shim (or class_alias) to keep the old FQCN working for a transition period.
    plugins/jwt-auth/src/JwtAuthPlugin.php:13
  • Renaming this class from Plugin to JwtAuthPlugin is a backwards-incompatible change for any external code referencing MixerApi\\JwtAuth\\Plugin. If you need to preserve BC, consider adding a deprecated Plugin shim class (or class_alias) so existing consumers don’t break.
    plugins/crud/src/CrudPlugin.php:20
  • Renaming the plugin entry class from Plugin to CrudPlugin is a BC break for any consumers referencing MixerApi\\Crud\\Plugin. If this plugin is published/consumed externally, consider adding a deprecated Plugin shim class (or class_alias) to maintain compatibility during the transition.
    plugins/bake/src/BakePlugin.php:14
  • Renaming the plugin entry class from Plugin to BakePlugin is a BC break for consumers that still reference MixerApi\\Bake\\Plugin. If backwards compatibility is a goal, consider adding a deprecated Plugin shim class (or class_alias) to preserve the old FQCN while transitioning.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant