Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 62 additions & 9 deletions mixpanel/flags/local_feature_flags.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import asyncio
import time
import threading
import json_logic
from datetime import datetime, timedelta
from typing import Dict, Any, Callable, Optional
from .types import (
Expand All @@ -23,7 +24,6 @@
logger = logging.getLogger(__name__)
logging.getLogger("httpx").setLevel(logging.ERROR)


class LocalFeatureFlagsProvider:
FLAGS_DEFINITIONS_URL_PATH = "/flags/definitions"

Expand Down Expand Up @@ -312,29 +312,82 @@ def _get_assigned_rollout(
rollout_hash = normalized_hash(str(context_value), salt)

if (rollout_hash < rollout.rollout_percentage
and self._is_runtime_evaluation_satisfied(rollout, context)
and self._is_runtime_rules_engine_satisfied(rollout, context)
):
return rollout

return None

def lowercase_keys_and_values(self, val: Any) -> Any:
if isinstance(val, str):
return val.casefold()
elif isinstance(val, list):
return [self.lowercase_keys_and_values(item) for item in val]
elif isinstance(val, dict):
return {
(key.casefold() if isinstance(key, str) else key):
self.lowercase_keys_and_values(value)
for key, value in val.items()
}
else:
return val

def lowercase_only_leaf_nodes(self, val: Any) -> Dict[str, Any]:
if isinstance(val, str):
return val.casefold()
elif isinstance(val, list):
return [self.lowercase_only_leaf_nodes(item) for item in val]
elif isinstance(val, dict):
return {
key:
self.lowercase_only_leaf_nodes(value)
for key, value in val.items()
}
else:
return val

def _get_runtime_parameters(self, context: Dict[str, Any]) -> Optional[Dict[str, Any]]:
if not (custom_properties := context.get("custom_properties")):
return None
if not isinstance(custom_properties, dict):
return None
return self.lowercase_keys_and_values(custom_properties)

def _is_runtime_rules_engine_satisfied(self, rollout: Rollout, context: Dict[str, Any]) -> bool:
if rollout.runtime_evaluation_rule:
parameters_for_runtime_rule = self._get_runtime_parameters(context)
if parameters_for_runtime_rule is None:
return False

def _is_runtime_evaluation_satisfied(
try:
rule = self.lowercase_only_leaf_nodes(rollout.runtime_evaluation_rule)
result = json_logic.jsonLogic(rule, parameters_for_runtime_rule)
return bool(result)
except Exception:
logger.exception("Error evaluating runtime evaluation rule")
return False

elif rollout.runtime_evaluation_definition: # legacy field supporting only exact match conditions
return self._is_legacy_runtime_evaluation_rule_satisfied(rollout, context)

else:
return True

def _is_legacy_runtime_evaluation_rule_satisfied(
self, rollout: Rollout, context: Dict[str, Any]
) -> bool:
if not rollout.runtime_evaluation_definition:
return True

if not (custom_properties := context.get("custom_properties")):
return False

if not isinstance(custom_properties, dict):
parameters_for_runtime_rule = self._get_runtime_parameters(context)
if parameters_for_runtime_rule is None:
return False

for key, expected_value in rollout.runtime_evaluation_definition.items():
if key not in custom_properties:
if key not in parameters_for_runtime_rule:
return False

actual_value = custom_properties[key]
actual_value = parameters_for_runtime_rule[key]
if actual_value.casefold() != expected_value.casefold():
return False

Expand Down
Loading
Loading