-
Notifications
You must be signed in to change notification settings - Fork 244
Closed
Description
Just checked out the diffs from 2.7.4 -> 2.7.5 and I'm glad to see the library moving away from objc_sync's towards dispatch queues!!!
A few quick questions:
-For the new queues (and all, really), would it be wise to assign them a QoS of .utility? Since this is a background process we probably don't want any of these events getting serviced on UI-sensitive main.
-I shouldn't technically be necessary, but I've found it's best practice to capture objects when doing .sync and .async calls to another queue.
let thing = Thing()
myQueue.sync { [thing] in
thing.doSomething()
}
AFAIK it costs nothing and can save some headaches down the road when weird, nonsensical BAD_ACCESS crashes start showing up.
Thanks for another update :)
Metadata
Metadata
Assignees
Labels
No labels