Remove using IFA as distinct id #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- After iOS 14, accessing IFA will require an app developer to obtain an end-user's consent via an opt-in. An app will need to obtain permission to access this unique identifier, it imposes some challenges for us like caching, permissions and usage of new frameworks and doesn't add a lot of value. We will default to the IFV(identifier vendor) instead. - Customers can still set/identify the distinct_id as IFA or `$ios_ifa property` by themselves if they have access to the advertising identifier.
patedit
reviewed
Jul 13, 2020
patedit
reviewed
Jul 13, 2020
Mixpanel/MixpanelInstance.swift
Outdated
| let distinctId = MixpanelInstance.macOSIdentifier() | ||
| #else | ||
| let distinctId: String? = nil | ||
| #endif // os(OSX) |
patedit
approved these changes
Jul 13, 2020
Co-authored-by: Sergio Alonso Fernández <patedit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Active Compilation Conditionsbuild settings.$ios_ifa propertyby themselves if they have access to the advertising identifier.