Skip to content

Fix events being dropped when flushing if there are corrupted items in the event queue #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 23, 2020
Merged

Fix events being dropped when flushing if there are corrupted items in the event queue #418

merged 9 commits into from
Nov 23, 2020

Conversation

@zihejia
Copy link
Contributor

@zihejia zihejia commented Nov 19, 2020 •
edited
Loading

  • Fix events being dropped when flushing if there are corrupted items in the event queue (filter out the bad event rather than dropping the whole batch of queue)
  • safe guard the invalid numbers from being infinite or NaN before sending to Mixpanel

@zihejia zihejia force-pushed the flush-tweaking branch 4 times, most recently from b9f1b17 to 718269f Compare November 23, 2020 05:08
jaredmixpanel
jaredmixpanel reviewed Nov 23, 2020
View reviewed changes
MixpanelDemo/MixpanelDemo/TrackingViewController.swift Outdated
descStr = "Event: \"\(ev)\""
case 1:
let ev = "Track Event With Properties!"
let ev = "Track Event With Properties! No: \(eventNo)"
Copy link
Contributor

@jaredmixpanel jaredmixpanel Nov 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this example, I would make the event number a property and keep the event name consistent

Copy link
Contributor Author

@zihejia zihejia Nov 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thx for catching this

@zihejia zihejia changed the title Flush tweaking Fix events being dropped when flushing if there are corrupted items in the event queue Nov 23, 2020
jaredmixpanel
jaredmixpanel reviewed Nov 23, 2020
View reviewed changes
jaredmixpanel
jaredmixpanel approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@jaredmixpanel jaredmixpanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zihejia zihejia merged commit be0d9e6 into master Nov 23, 2020
@zihejia zihejia deleted the flush-tweaking branch January 26, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaredmixpanel jaredmixpanel jaredmixpanel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zihejia @jaredmixpanel