Remove alias check #425
Merged
Remove alias check #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing a check for the alias within the identify function as it can prevent the ID from changing if alias has been called already.
zihejia
reviewed
Jan 11, 2021
| self.people.distinctId = nil | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
minor nit: pls format the code. otherwise, it looks good.
Contributor
Author
There was a problem hiding this comment.
I've also added a fix to also encode "+" within URLs which was causing some decide requests not to fetch data.
Fixing formatting for code refactor within the identify call in MixpanelInstance Adding line to URL encode the + sign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing a check for the alias within the identify function as it can prevent the ID from changing if alias has been called already.