Merged
Conversation
f52939a to
ffc11b0
Compare
Contributor
Author
|
update: I have also added freebsd specific process commands. the main one that was failing is the |
Owner
|
LGTM. Thanks. |
Owner
|
Released as v2.71.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Ill start by saying im not too familiar with your code base and will admit up front im not sure how to test the changes other then manully patching the file on my system and re running my my beacker tests.
The main issues is that the following check is returning false on FreeBSD 10.3, running in VirtualBOX via vagrant.
looking at the code and running it manually via
irbsuggests that there are unnecessary escapehopefully this patch is useful but and happy to work on it more if you point me into the rigvht direction
Thanks