Is there any way to do async login?

[anderspitman]

I'm trying to integrate this library into a BeeWare GUI app, and having async issues. I suspect it's because from_login is synchronous. Is there any way to perform async login, or is there perhaps another cause of my problem?

[mkb79]

@anderspitman

I've created the branch https://github.com/mkb79/Audible/tree/issue/make-login-async. Can you try it out and report back?!

Edit:
I wrote the code with my iPhone and does not verified it. But it should work.

[anderspitman]

Wow that was quick thank you!

It's almost working. I just needed to await otp_callback for my code to work:

Audible/src/audible/login.py

Line 488 in 2e4390f

otp_code = otp_callback()

[mkb79]

Wow that was quick thank you!

It's almost working. I just needed to await otp_callback for my code to work:

Audible/src/audible/login.py

Line 488 in 2e4390f

otp_code = otp_callback()

Good to hear that! You are using your own otp callback function? Then yes, this must be awaited too.

[anderspitman]

Yeah custom otp_callback because I'm showing an input dialog to the user if the OTP is triggered. I'll likely need to do the same for the other callbacks

[mkb79]

Yeah custom otp_callback because I'm showing an input dialog to the user if the OTP is triggered. I'll likely need to do the same for the other callbacks

Ah, okay. I doesn't know that. Than you have to await your other custom callbacks in the login function too, if they are coroutines/Awaitables.

[anderspitman]

Is there a way to implement it in your library so that it works whether the user provides a sync or async callback? Not sure if that's possible in Python

[mkb79]

@anderspitman
Only the login function needs packages like beautifulsoup or pillow. So I've tinking about outsourcing the login and register function in a separate package. This way the main package needs less dependencies. Then I can implement sync and async functions without overhaul the main package.

[github-actions]

This issue has not been updated for a while and will be closed soon.

[github-actions]

This issue has automatically been closed due to no activities.

[anderspitman]

@mkb79 is this still planned eventually?

[github-actions]

This issue has not been updated for a while and will be closed soon.