-
Notifications
You must be signed in to change notification settings - Fork 3
Release 1.1.1 #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.1.1 #27
Conversation
WalkthroughThe Makefile’s VERSION variable was updated from 1.1.0 to 1.1.1, impacting derived artifact names and references that interpolate ${VERSION}. No other logic or build steps were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
Makefile(1 hunks)
| NAME=openai | ||
| BINARY=terraform-provider-${NAME} | ||
| VERSION=1.1.0 | ||
| VERSION=1.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Version bump to 1.1.1 looks good.
No build logic changes; artifacts and install paths will follow the new VERSION. Consider a couple of small improvements while you're here.
- Add linux/arm64 to release matrix (popular on CI/cloud runners).
- Mark the default target as phony.
- Optionally set CGO_ENABLED=0 and use -trimpath for smaller, reliably cross-compiled binaries.
Diffs:
@@
VERSION=1.1.1
@@
release:
mkdir -p ./bin
GOOS=darwin GOARCH=amd64 go build -o ./bin/${BINARY}_${VERSION}_darwin_amd64
GOOS=darwin GOARCH=arm64 go build -o ./bin/${BINARY}_${VERSION}_darwin_arm64
@@
GOOS=linux GOARCH=386 go build -o ./bin/${BINARY}_${VERSION}_linux_386
GOOS=linux GOARCH=amd64 go build -o ./bin/${BINARY}_${VERSION}_linux_amd64
+ GOOS=linux GOARCH=arm64 go build -o ./bin/${BINARY}_${VERSION}_linux_arm64
GOOS=linux GOARCH=arm go build -o ./bin/${BINARY}_${VERSION}_linux_arm
@@
-.PHONY: build fmt lint test testacc install install-dev clean release
+.PHONY: default build fmt lint test testacc install install-dev clean releaseIf you want the cross-builds fully static/smaller (optional):
@@
-build:
- go build -o ${BINARY}
+build:
+ CGO_ENABLED=0 go build -trimpath -o ${BINARY}
@@
- GOOS=darwin GOARCH=amd64 go build -o ./bin/${BINARY}_${VERSION}_darwin_amd64
+ CGO_ENABLED=0 GOOS=darwin GOARCH=amd64 go build -trimpath -o ./bin/${BINARY}_${VERSION}_darwin_amd64Quick checks to run:
🏁 Script executed:
#!/bin/bash
# Verify tag and references for 1.1.1
git tag -l 'v1.1.1'
rg -n --hidden -S '\b1\.1\.1\b' -g '!**/vendor/**'Length of output: 98
Add missing v1.1.1 Git tag and apply suggested Makefile improvements
- Create and push the v1.1.1 tag to mark this release (e.g.
git tag v1.1.1 && git push origin v1.1.1). - Add
GOOS=linux GOARCH=arm64build line under the release target. - Include
defaultin your.PHONYdeclaration. - (Optional) For fully static, smaller binaries set
CGO_ENABLED=0and add-trimpathtogo build.
🤖 Prompt for AI Agents
Makefile around line 10: add a v1.1.1 Git tag and update the Makefile per
review: create and push the tag (e.g. run `git tag v1.1.1 && git push origin
v1.1.1`), update the release target to also build for GOOS=linux GOARCH=arm64,
add default to the .PHONY declaration, and (optionally) set CGO_ENABLED=0 and
add -trimpath to the go build flags to produce smaller, fully static binaries.
Summary by CodeRabbit