Implemented persistent reorder todo list functionality#15
Merged
mblomdahl merged 2 commits intomkdevops-se:masterfrom Nov 3, 2024
Merged
Implemented persistent reorder todo list functionality#15mblomdahl merged 2 commits intomkdevops-se:masterfrom
mblomdahl merged 2 commits intomkdevops-se:masterfrom
Conversation
okaziya
reviewed
Nov 2, 2024
okaziya
approved these changes
Nov 2, 2024
mblomdahl
approved these changes
Nov 2, 2024
Member
mblomdahl
left a comment
mblomdahl
left a comment
There was a problem hiding this comment.
Works beautifully from my testing! Great job @Steinvall! 🙃
Author
|
Please merge this pull request at your convenience @mblomdahl (I can't since I don't have write access to the repository). Unless there is something else you want me to change/fix, of course. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses this issue
Frontend: Added “react-beautiful-dnd” for drag and drop functionality on the todo list
Backend: Added “order” attribute on TodoItem entity and added backend API “/reorder” to persist changes across different clients/browsers (even if it’s just an in-memory database at the moment)
@mblomdahl