Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Theme: File Listing Overflow #1234

Closed
csm10495 opened this issue Jun 5, 2017 · 0 comments
Closed

Default Theme: File Listing Overflow #1234

csm10495 opened this issue Jun 5, 2017 · 0 comments
Labels
Bug Theme-mkdocs Issues specifically involving the mkdocs theme.
Milestone
1.1

Comments

@csm10495
Copy link

csm10495 commented Jun 5, 2017 •
edited
Loading

When having a lot of files, the drop down will overflow beyond the page height.
image

I tried adding a max height / overflow-y via CSS:

.dropdown-menu{
  overflow-y: auto;
  max-height: 85vh;
}

Though that led to more weird behavior:

image

It looks like the overflow is leading to the child dropdowns being contained within the existing one. Weird.

I'm sure there is a way to do this with CSS, and I'm imagining it would make sense to make it into the theme. Much thanks!
@csm10495 csm10495 changed the title Default Theme:File Listing Overflow Default Theme: File Listing Overflow Jun 5, 2017
@waylan waylan added the Bug label Jun 5, 2017
@waylan waylan added the Theme-general Issues involving the theme related code within MkDocs label Nov 1, 2017
@waylan waylan added this to the Post 1.0 milestone Feb 6, 2018
@waylan waylan added Theme-mkdocs Issues specifically involving the mkdocs theme. and removed Theme-general Issues involving the theme related code within MkDocs labels Aug 22, 2018
@waylan waylan modified the milestones: Post 1.0, 1.1 Aug 23, 2018
@waylan waylan mentioned this issue Dec 27, 2019
Closed
jimporter added a commit to jimporter/mkdocs that referenced this issue Jan 29, 2020
@jimporter
Improve support for long dropdowns in the mkdocs theme; resolves mkdo…
7073fdc 
…cs#1234

This patch allows dropdowns with many items to scroll, rather than overflowing
beyond the bounds of the page. Due to the complexities of CSS, this requires
nested dropdowns to be given a fixed position which is initialized via JS.

In addition, this patch changes the behavior of nested dropdowns to require a
click to open (more consistent with the root dropdown, and improves UX on
mobile devices). It also fixes the UI on small screens, adding the nested
dropdown "in-place" when it's opened and allowing the whole navbar to scroll
if there are many items.
jimporter added a commit to jimporter/mkdocs that referenced this issue Jan 29, 2020
@jimporter
Improve support for long dropdowns in the mkdocs theme; resolves mkdo…
1d19041 
…cs#1234

This patch allows dropdowns with many items to scroll, rather than overflowing
beyond the bounds of the page. Due to the complexities of CSS, this requires
nested dropdowns to be given a fixed position which is initialized via JS.

In addition, this patch changes the behavior of nested dropdowns to require a
click to open (more consistent with the root dropdown, and improves UX on
mobile devices). It also fixes the UI on small screens, adding the nested
dropdown "in-place" when it's opened and allowing the whole navbar to scroll
if there are many items.
jimporter added a commit to jimporter/mkdocs that referenced this issue Jan 29, 2020
@jimporter
Improve support for long dropdowns in the mkdocs theme; resolves mkdo…
1712b25 
…cs#1234

This patch allows dropdowns with many items to scroll, rather than overflowing
beyond the bounds of the page. Due to the complexities of CSS, this requires
nested dropdowns to be given a fixed position which is initialized via JS.

In addition, this patch changes the behavior of nested dropdowns to require a
click to open (more consistent with the root dropdown, and improves UX on
mobile devices). It also fixes the UI on small screens, adding the nested
dropdown "in-place" when it's opened and allowing the whole navbar to scroll
if there are many items.
jimporter added a commit to jimporter/mkdocs that referenced this issue Jan 29, 2020
@jimporter
Improve support for long dropdowns in the mkdocs theme; resolves mkdo…
e066f33 
…cs#1234

This patch allows dropdowns with many items to scroll, rather than overflowing
beyond the bounds of the page. Due to the complexities of CSS, this requires
nested dropdowns to be given a fixed position which is initialized via JS.

In addition, this patch changes the behavior of nested dropdowns to require a
click to open (more consistent with the root dropdown, and improves UX on
mobile devices). It also fixes the UI on small screens, adding the nested
dropdown "in-place" when it's opened and allowing the whole navbar to scroll
if there are many items.
@waylan waylan closed this as completed in 535505b Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Theme-mkdocs Issues specifically involving the mkdocs theme.
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
2 participants
@waylan @csm10495