Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to newer version of ghp-import #2170

Closed
waylan opened this issue Aug 20, 2020 · 1 comment · Fixed by #2257
Closed

Update to newer version of ghp-import #2170

waylan opened this issue Aug 20, 2020 · 1 comment · Fixed by #2257

Comments

@waylan
Copy link
Member

waylan commented Aug 20, 2020

Currently we are using a vendored (and modified) copy of ghp-import. Recently version 1.0.0 of the package has been released which includes the changes in c-w/ghp-import#69. That makes it possible to call ghp-import directly from Python without the modifications in our vendored copy. Therefore we should consider removing our vendored copy and and ghp-import=1.0 to our list of dependencies.

@waylan
Copy link
Member Author

waylan commented Nov 9, 2020

Doing this will also fix #1383.

@waylan waylan added this to the 1.2 milestone Dec 19, 2020
waylan added a commit to waylan/mkdocs that referenced this issue Dec 20, 2020
Replace vendored (and modified) copy of ghp_import with dependency on
upstream library. As of version 1.0+ ghp_import includes a Python API.
MkDocs can now benefit from recent bugfixes and new features (mkdocs#2170).
waylan added a commit to waylan/mkdocs that referenced this issue Dec 21, 2020
waylan added a commit to waylan/mkdocs that referenced this issue Dec 21, 2020
waylan added a commit to waylan/mkdocs that referenced this issue Dec 21, 2020
waylan added a commit that referenced this issue Dec 21, 2020
Replace vendored (and modified) copy of ghp_import with dependency on
upstream library. As of version 1.0+ ghp_import includes a Python API.

MkDocs can now benefit from recent bug fixes and new features, including the following:

* A `.nojekyll` file is automatically included when deploying to GitHub Pages.
* The `--shell` flag is now available, which reportedly works better on Windows.
* Git author and committer environment variables should be respected.

Resolves #2170 and resolves #1383.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant