Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ReadTheDocs to use latest MkDocs #554

Closed
d0ugal opened this issue May 25, 2015 · 11 comments
Closed

Update ReadTheDocs to use latest MkDocs #554

d0ugal opened this issue May 25, 2015 · 11 comments
Labels

Comments

@d0ugal
Copy link
Member

@d0ugal d0ugal commented May 25, 2015

This is really an upstream issue, but I want to track it here for downstream users.

@d0ugal
Copy link
Member Author

@d0ugal d0ugal commented May 25, 2015

readthedocs.org is currently running 0.11.1 this means that they are missing all of these lovely commits which is roughly half of the MkDocs git history (based on number of commits).

@d0ugal
Copy link
Member Author

@d0ugal d0ugal commented May 25, 2015

After I roll a 0.13.0 release in the next few days I will be working on updating readthedocs to use it, currently there are problems due to the theme customisations they make.

@ericholscher
Copy link
Contributor

@ericholscher ericholscher commented May 27, 2015

👍 Happy to merge & deploy the new version when it's ready.

@d0ugal
Copy link
Member Author

@d0ugal d0ugal commented May 28, 2015

@ericholscher Thanks! Can we define what blocks are needed from themes so they work on ReadTheDocs? See #355 and readthedocs/readthedocs.org#978 (comment). I want to add blocks and reduce the duplication of the theme that you guys have - this should then reduce the risk of us breaking something if you only inject into small defined areas. We can then document that and add support in other themes.

@d0ugal
Copy link
Member Author

@d0ugal d0ugal commented May 30, 2015

@d0ugal
Copy link
Member Author

@d0ugal d0ugal commented Jun 1, 2015

This just landed in ReadTheDocs! w00t!

@d0ugal d0ugal closed this Jun 1, 2015
@deejay1
Copy link

@deejay1 deejay1 commented Aug 13, 2015

Seems like this has regressed in the latest master...

@d0ugal
Copy link
Member Author

@d0ugal d0ugal commented Aug 13, 2015

@deejay1 What has?

@deejay1
Copy link

@deejay1 deejay1 commented Aug 13, 2015

@d0ugal mkdocs documents have problems with links not having trailing slashed and resulting in having "somedirectoryindex.html" in them

@d0ugal
Copy link
Member Author

@d0ugal d0ugal commented Aug 13, 2015

@deejay1 That sounds unrelated to this issue - can you open a new one with an example? It might be that this is a problem with RTD itself and it needs to be reported upstream (we have not changed anything lately)

@deejay1
Copy link

@deejay1 deejay1 commented Aug 13, 2015

@d0ugal Ah sorry, got a bit confused with the links back and forth on that issue and commented on the wrong project :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants