-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
search encoding bug #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Ah, that it annoying. I guess this happens on the ReadTheDocs theme? |
Confirmed here with the RTD theme. The space gets converted to "+", and then to %2B (so still "+"), and then each successive 'enter' adds a %25 ("%"?) - so: some text System, FWIW:
|
Thanks, good catch. I can see how that would happen. I'll look into a fix if nobody else does it first :) |
`getSearchTerm()`. Fixes mkdocs#586.
I think I fixed it... See my commit. I gather the plus replacement is necessary because GET forms encode their data with a different encoding specification to JavaScript's |
@samhatfield Yup, that makes sense. Looks good, can you open a pull request? |
Hello,
for example you search for:
some fonts
it becomes
some+fonts
when you press enter again, it becomes
some%2Bfonts
cheers
The text was updated successfully, but these errors were encountered: