Skip to content

Change build system to hatchling#430

Merged
pawamoy merged 8 commits intomainfrom
b/use-hatchling-build-system
Nov 18, 2025
Merged

Change build system to hatchling#430
pawamoy merged 8 commits intomainfrom
b/use-hatchling-build-system

Conversation

@johnslavik
Copy link
Member

@johnslavik johnslavik commented Nov 17, 2025

Seems like it outputs the same thing.

@johnslavik johnslavik force-pushed the b/use-hatchling-build-system branch from fb821c8 to e48c5f0 Compare November 17, 2025 15:46
@johnslavik
Copy link
Member Author

johnslavik commented Nov 17, 2025

Did this simple test setup:

#!/usr/bin/env bash

set -HCETeuxo pipefail

TEST_TAG="v9.9.99"

rm -rf {before,after}
mkdir -p {before,after}/{sdist,wheel}

git checkout main
git tag -fsam 'Test' "$TEST_TAG"
uv build --{sdist,wheel} -o before

git checkout b/use-hatchling-build-system
git tag -fsam 'Test' "$TEST_TAG"
uv build --{sdist,wheel} -o after

tar -xzf before/*.gz -C before/sdist
tar -xzf after/*.gz -C after/sdist

unzip before/*.whl -d before/wheel
unzip after/*.whl -d after/wheel

git tag -d "$TEST_TAG"

for dir in {before,after}/{sdist,wheel}; do
    fname="${dir//\//.}"
    du -Sh "$dir" | sort -h >| "du.$fname"
    tree "$dir" >| "tree.$fname"
done

diff <(sed 's#before/##g' du.before.sdist) <(sed 's#after/##g' du.after.sdist)
diff <(sed 's#before/##g' du.before.wheel) <(sed 's#after/##g' du.after.wheel)
diff <(sed 's#before/##g' tree.before.sdist) <(sed 's#after/##g' tree.after.sdist)
diff <(sed 's#before/##g' tree.before.wheel) <(sed 's#after/##g' tree.after.wheel)

Comparing du.before.sdist and du.after.sdist caught that the sdist is missing the src directory, gonna fix it

@johnslavik johnslavik force-pushed the b/use-hatchling-build-system branch from b201448 to 72f650a Compare November 17, 2025 16:33
@johnslavik johnslavik force-pushed the b/use-hatchling-build-system branch from 72f650a to 11148b2 Compare November 17, 2025 16:34
@johnslavik
Copy link
Member Author

Ok, seems fine?

@johnslavik johnslavik marked this pull request as ready for review November 17, 2025 16:46
@johnslavik johnslavik requested a review from pawamoy November 17, 2025 16:46
@johnslavik
Copy link
Member Author

Re-trigger CI

@johnslavik johnslavik closed this Nov 17, 2025
@johnslavik johnslavik reopened this Nov 17, 2025
Copy link
Member

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pawamoy
Copy link
Member

pawamoy commented Nov 17, 2025

Damn annoying operating system again.

@pawamoy pawamoy merged commit 09b0682 into main Nov 18, 2025
9 of 11 checks passed
@johnslavik johnslavik deleted the b/use-hatchling-build-system branch November 18, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants