Merged
Conversation
It's limited to u8 on Linux waitpid, not i32. Return ExitCode from sunsetc main() so that destructors run. Flush log on completion.
Wakers are now awoken by Runner, since that knows when the TrafOut or Kex (TODO) are ready for channel output. This fixes a hang where channels wouldn't get woken for write once SSH session data has been written out. Async inputs that don't have a live ChanIn or ChanInOut will be discarded, with refcounting to keep track of live instances. All in/out wakers are woken on close. There's some work towards removing functions in Channels and calling Channel functions directly from Runner (using from_handle_mut()), though more needs to be done in future commits.
Previously non-kex packets would be rejected after sending kexinit, but there could be packets in flight in front of the peer's own kexinit. Instead wait until the kexinit has been received.
Only KEX (or a few transport) packets are allowed. Further work is needed to stop channel opens etc, though those aren't currently a problem for servers.
Got lost when moving to Event. Fixes: 06992a3 ("Replace Behaviour with Event")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.