Assorted cleanups#49
Merged
Merged
Conversation
No significant changes
Can go in the Client constrained implementation now that there is a generic CS parameter.
No functional change, the caller catches all errors.
to_str() rather than as_str(), since it needs to performa a utf-8 check. auth_methods() rather than get_auth_methods()
Most errors should be returned to the peer, but Error::Bug shouldn't ever happen. We want fuzzers etc to catch it.
Required for debug format of Runner<CS>
This is called on TrafSend rather than having a separate argument passed through rekey_send(). done_first_kex is no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various tidying, these should have no significant change in functionality.