Merged
Conversation
This change normalizes the handling of contract IDs across the teamwork, stones, and siab modules. Previously, the contract IDs were being converted to lowercase, which was unnecessary and could lead to issues with case-sensitive comparisons. The changes ensure that the contract IDs are used as-is, without any unnecessary transformations.
The changes in this commit add support for parade host and banker functionality in the contract system. The main changes are: - Conditionally add the "Parade Banker" and "Parade Host" sink options based on the contract's play style and the bot's configuration. - Add the "Banker" sink option for contracts with the `ContractFlagBanker` flag set during the signup state. - Always add the "Post Contract Sink" option. - Add a new `Parader` struct to hold data for each parader within a contract. - Update the `Contract` struct to include a `ParadeList` field to store the list of paraders. These changes allow the contract system to better support the parade feature, including the ability to designate a parade banker and host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.