feat(contract_scores): Implement new buff time value and teamwork calculations#1583
Merged
feat(contract_scores): Implement new buff time value and teamwork calculations#1583
Conversation
…culations This commit introduces changes to the contract score calculation logic: 1. Adds a new `calculateBuffTimeValue` function to compute the buff time value based on the contract version, segment duration, SIAB percentage, and Deflector percentage. 2. Introduces a new `calculateTeamworkB` function to compute the teamwork B score based on the contract version and buff time value. 3. Modifies the `calculateChickenRunTeamwork` function to handle the contract version-specific logic. 4. Updates the `calculateContractScore` function to use the new `getPredictedTeamwork` function, which considers the contract version when calculating the teamwork score. 5. Removes the cap on SIAB and Deflector percentages for CXP version 1 contracts, as they no longer have buff time value requirements. These changes aim to improve the accuracy and flexibility of the contract score calculation, especially for newer contract versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces changes to the contract score calculation logic:
calculateBuffTimeValuefunction to compute the buff time value based on the contract version, segment duration, SIAB percentage, and Deflector percentage.calculateTeamworkBfunction to compute the teamwork B score based on the contract version and buff time value.calculateChickenRunTeamworkfunction to handle the contract version-specific logic.calculateContractScorefunction to use the newgetPredictedTeamworkfunction, which considers the contract version when calculating the teamwork score.These changes aim to improve the accuracy and flexibility of the contract score calculation, especially for newer contract versions.