feat(score_explorer): Improve score explorer UI and functionality#1600
Merged
feat(score_explorer): Improve score explorer UI and functionality#1600
Conversation
This commit introduces several improvements to the score explorer feature: 1. Removes the hardcoded `fairShare` array and replaces it with a dynamic array that includes more granular values. 2. Changes the `FairShare` field in the `ScoreCalcParams` struct to be a `float64` instead of an `int`. 3. Replaces the static "Fair Share" button with a dynamic select menu that allows the user to choose from a range of fair share values. 4. Adds a deferred response to the interaction, displaying a "Processing request..." message while the score is being calculated. 5. Switches from using `InteractionRespond` to `FollowupMessageCreate` to send the final score explorer message, which allows for more flexibility in the message content. These changes improve the user experience by providing more granular control over the fair share value and making the UI more responsive and informative.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces several improvements to the score explorer feature:
fairSharearray and replaces it with a dynamic array that includes more granular values.FairSharefield in theScoreCalcParamsstruct to be afloat64instead of anint.InteractionRespondtoFollowupMessageCreateto send the final score explorer message, which allows for more flexibility in the message content.These changes improve the user experience by providing more granular control over the fair share value and making the UI more responsive and informative.