🔧 refactor(ci): Restructure GitHub Actions workflow for improved clarity#1918
🔧 refactor(ci): Restructure GitHub Actions workflow for improved clarity#1918
Conversation
There was a problem hiding this comment.
Pull request overview
This PR consolidates the CI workflows by removing the separate development.yml workflow and merging its functionality into ci.yml, resulting in a more organized and maintainable CI pipeline with explicit job dependencies.
- Removed redundant
development.ymlworkflow file - Restructured
ci.ymlwith separate jobs for format, test, lint, audit, and build - Added explicit job names and dependencies for clearer workflow execution order
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 13 comments.
| File | Description |
|---|---|
.github/workflows/development.yml |
Removed - functionality migrated to ci.yml |
.github/workflows/ci.yml |
Consolidated workflow with improved structure: added audit and build jobs, improved step naming consistency, and established job dependencies |
| @@ -15,7 +16,7 @@ jobs: | |||
| with: | |||
There was a problem hiding this comment.
Using @main for GitHub Actions is not recommended for production workflows. The @main branch can change unexpectedly and potentially break your CI pipeline. Consider pinning to a specific version tag (e.g., actions/setup-go@v5) or commit SHA for stability and reproducibility.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
| - name: Upload linux | ||
| uses: actions/upload-artifact@main | ||
| with: | ||
| name: boostbot-linux | ||
| path: output/linux | ||
| - name: Upload freebsd | ||
| uses: actions/upload-artifact@main | ||
| with: | ||
| name: boostbot-freebsd | ||
| path: output/freebsd No newline at end of file |
There was a problem hiding this comment.
The conditional if: startsWith(matrix.go-version,'1.25.5') from the original workflow has been removed. This means artifacts will now be uploaded for all Go versions in the matrix. While the current matrix only contains one version, if additional versions are added later, this could result in duplicate artifacts or unexpected behavior. Consider either: (1) keeping the conditional if the matrix might expand, or (2) removing the matrix entirely since only one Go version is used.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
| check-latest: true | ||
| - name: Code | ||
| - name: Checkout code | ||
| uses: actions/checkout@main |
There was a problem hiding this comment.
Using @main for GitHub Actions is not recommended for production workflows. The @main branch can change unexpectedly and potentially break your CI pipeline. Consider pinning to a specific version tag (e.g., actions/checkout@v4) or commit SHA for stability and reproducibility.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
| @@ -30,9 +31,10 @@ jobs: | |||
| uses: actions/setup-go@main | |||
There was a problem hiding this comment.
Using @main for GitHub Actions is not recommended for production workflows. The @main branch can change unexpectedly and potentially break your CI pipeline. Consider pinning to a specific version tag (e.g., actions/setup-go@v5) or commit SHA for stability and reproducibility.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
| go-version: '1.25.5' | ||
| - name: Code | ||
| - name: Checkout code | ||
| uses: actions/checkout@main |
There was a problem hiding this comment.
Using @main for GitHub Actions is not recommended for production workflows. The @main branch can change unexpectedly and potentially break your CI pipeline. Consider pinning to a specific version tag (e.g., actions/checkout@v4) or commit SHA for stability and reproducibility.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
| name: boostbot-linux | ||
| path: output/linux | ||
| - name: Upload freebsd | ||
| uses: actions/upload-artifact@main |
There was a problem hiding this comment.
Using @main for GitHub Actions is not recommended for production workflows. The @main branch can change unexpectedly and potentially break your CI pipeline. Consider pinning to a specific version tag (e.g., actions/upload-artifact@v4) or commit SHA for stability and reproducibility.
| uses: actions/upload-artifact@main | |
| uses: actions/upload-artifact@v4 |
| go-version: ${{ matrix.go-version }} | ||
| - name: Code | ||
| - name: Checkout code | ||
| uses: actions/checkout@main |
There was a problem hiding this comment.
Using @main for GitHub Actions is not recommended for production workflows. The @main branch can change unexpectedly and potentially break your CI pipeline. Consider pinning to a specific version tag (e.g., actions/checkout@v4) or commit SHA for stability and reproducibility.
| @@ -41,11 +43,55 @@ jobs: | |||
| uses: actions/setup-go@main | |||
There was a problem hiding this comment.
Using @main for GitHub Actions is not recommended for production workflows. The @main branch can change unexpectedly and potentially break your CI pipeline. Consider pinning to a specific version tag (e.g., actions/setup-go@v5) or commit SHA for stability and reproducibility.
| with: | ||
| go-version: ${{ matrix.go-version }} | ||
| - name: Checkout code | ||
| uses: actions/checkout@main |
There was a problem hiding this comment.
Using @main for GitHub Actions is not recommended for production workflows. The @main branch can change unexpectedly and potentially break your CI pipeline. Consider pinning to a specific version tag (e.g., actions/checkout@v4) or commit SHA for stability and reproducibility.
| with: | ||
| go-version: '1.25.5' | ||
| - name: Checkout code | ||
| uses: actions/checkout@main |
There was a problem hiding this comment.
Using @main for GitHub Actions is not recommended for production workflows. The @main branch can change unexpectedly and potentially break your CI pipeline. Consider pinning to a specific version tag (e.g., actions/checkout@v4) or commit SHA for stability and reproducibility.
1 participant
No description provided.