🔧 fix: ensure farmer exists before accessing tokens#1937
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a nil check to the GetTokens function to prevent potential nil pointer dereference errors when accessing a farmer's tokens. The fix ensures that if a farmer doesn't exist for the given userID, a new farmer is created before attempting to access their token count.
Key Changes
- Added nil check and
newFarmer()call inGetTokensfunction to ensure farmer exists before token access - Aligns with the existing defensive programming pattern used in other getter/setter functions in the file
Comments suppressed due to low confidence (1)
src/farmerstate/farmerstate.go:235
- The nil check on lines 229-231 makes the subsequent check on line 232 redundant. After calling newFarmer(userID), farmerstate[userID] is guaranteed to be non-nil, so the ok check will always be true. Consider simplifying this to directly return farmerstate[userID].Tokens after the nil check, similar to the pattern used in GetMissionShipSecondary (lines 208-213).
if farmerstate, ok := farmerstate[userID]; ok {
return farmerstate.Tokens
}
return 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.