🥚 feat(emoji): Update eggcycle Makefile target with new emoji path#1944
Merged
🥚 feat(emoji): Update eggcycle Makefile target with new emoji path#1944
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the eggcycle Makefile target to use the proper emoji directory path for input files and adds a new egg variant to the animation sequence.
Key changes:
- Updated all input image paths to use the
emoji/prefix for consistency with the project structure - Added
emoji/egg_pegg.pngto the animation sequence - Simplified the ImageMagick command from
magick converttomagick
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Makefile | Updated the eggcycle target to prefix all egg PNG files with emoji/ directory path and added egg_pegg.png to the animation sequence |
| emoji/collegg.gif | Added the output GIF file containing the animated egg cycle |
| emoji/egg_silicon.png \ | ||
| emoji/egg_waterballoon.png \ | ||
| emoji/egg_wood.png \ | ||
| collegg.gif No newline at end of file |
There was a problem hiding this comment.
The output path for the generated GIF file should be prefixed with emoji/ to be consistent with the input paths. Currently, the command will create collegg.gif in the root directory instead of the emoji/ directory where the source images are located.
Suggested change
| collegg.gif | |
| emoji/collegg.gif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.