🚀 feat(estimate): Improve contract duration calculation debug mode#1949
Merged
🚀 feat(estimate): Improve contract duration calculation debug mode#1949
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the contract duration calculation functionality by adding a debug mode parameter that enables detailed logging of calculation steps. The primary purpose is to improve debugging capabilities for contract duration estimates.
Key changes:
- Added a
debugboolean parameter togetContractDurationEstimatefunction to control logging - Refactored the calculation logic to separate modifier components (
modHab,modELR,modShip) and collectible values (colHab,colELR,colShip) for clearer calculations - Uncommented and updated debug logging statements to log intermediate calculation values when debug mode is enabled
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/boost/estimate_time.go | Added debug parameter to function signature, separated modifier calculations, added colHab tracking, and enabled conditional debug logging |
| src/boost/boost_import.go | Updated function calls to pass the new debug parameter (set to false by default) with commented-out debug activation code |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.