🐛 fix(replay): move coopID retrieval from agent to evaluation#1954
Merged
🐛 fix(replay): move coopID retrieval from agent to evaluation#1954
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug by correcting where the coop identifier is retrieved from when processing archived contracts. The change moves the retrieval from the LocalContract (agent) to the ContractEvaluation object, which is the proper source for this data according to the evaluation-based contract processing logic.
Key Changes
- Reorders the coopID retrieval to occur after the evaluation is obtained from the contract
- Changes the source of coopID from
a.GetCoopIdentifier()toevaluation.GetCoopIdentifier()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.