Skip to content

🚀Enhance contract duration estimation withd boost calculations#1957

Merged
mkmccarty merged 4 commits intomainfrom
mm-branch-1
Dec 18, 2025
Merged

🚀Enhance contract duration estimation withd boost calculations#1957
mkmccarty merged 4 commits intomainfrom
mm-branch-1

Conversation

@mkmccarty
Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings December 18, 2025 06:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances contract duration estimation by adding maximum duration and CXP (contract experience points) calculations based on optimal artifact configurations. The changes introduce a third estimation scenario using a 10-slot "leggacy" artifact set with 5 boost tokens, providing a more accurate upper bound for contract completion.

Key changes:

  • Added EstimatedDurationMax and CxpMax fields to track maximum possible scores with optimal configurations
  • Implemented new estimation logic for 10-slot artifact configurations with iterative optimization
  • Updated display logic to show maximum potential scores instead of standard scores for better player guidance

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.

File Description
src/ei/ei_data.go Adds EstimatedDurationMax and CxpMax fields to the EggIncContract struct
src/boost/estimate_time.go Extends getContractDurationEstimate to return three durations and adds 10-slot artifact calculation logic
src/boost/boost_import.go Updates function calls to capture the new max duration value and calculates CxpMax using the duration modifier
src/boost/replay.go Updates UI to display CxpMax instead of Cxp and adds explanatory footer about estimation parameters

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/boost/replay.go
Comment thread src/boost/estimate_time.go Outdated
Comment thread src/boost/boost_import.go
Comment thread src/boost/estimate_time.go
Comment thread src/boost/replay.go
Comment thread src/boost/estimate_time.go Outdated
Comment on lines +366 to +368
tachStones := slots +
((modShip * colShip) / (modELR * colELR * modHab * colHab)) -
deflectorsOnFarmer*slots/(slots+(modShip*colShip)/(modELR*colELR*modHab*colHab))
Copy link

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable shadowing issue: tachStones is declared with := here, which creates a new local variable that shadows the outer tachStones declared at line 320. This means the value computed here won't be visible in the debug logging section. Use = instead of := to assign to the existing variable.

Copilot uses AI. Check for mistakes.
Comment thread src/boost/boost_import.go Outdated
mkmccarty and others added 3 commits December 17, 2025 22:30
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mkmccarty mkmccarty merged commit 2c4a688 into main Dec 18, 2025
6 of 12 checks passed
@mkmccarty mkmccarty deleted the mm-branch-1 branch December 18, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants