🚀Enhance contract duration estimation withd boost calculations#1957
🚀Enhance contract duration estimation withd boost calculations#1957
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances contract duration estimation by adding maximum duration and CXP (contract experience points) calculations based on optimal artifact configurations. The changes introduce a third estimation scenario using a 10-slot "leggacy" artifact set with 5 boost tokens, providing a more accurate upper bound for contract completion.
Key changes:
- Added
EstimatedDurationMaxandCxpMaxfields to track maximum possible scores with optimal configurations - Implemented new estimation logic for 10-slot artifact configurations with iterative optimization
- Updated display logic to show maximum potential scores instead of standard scores for better player guidance
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| src/ei/ei_data.go | Adds EstimatedDurationMax and CxpMax fields to the EggIncContract struct |
| src/boost/estimate_time.go | Extends getContractDurationEstimate to return three durations and adds 10-slot artifact calculation logic |
| src/boost/boost_import.go | Updates function calls to capture the new max duration value and calculates CxpMax using the duration modifier |
| src/boost/replay.go | Updates UI to display CxpMax instead of Cxp and adds explanatory footer about estimation parameters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| tachStones := slots + | ||
| ((modShip * colShip) / (modELR * colELR * modHab * colHab)) - | ||
| deflectorsOnFarmer*slots/(slots+(modShip*colShip)/(modELR*colELR*modHab*colHab)) |
There was a problem hiding this comment.
Variable shadowing issue: tachStones is declared with := here, which creates a new local variable that shadows the outer tachStones declared at line 320. This means the value computed here won't be visible in the debug logging section. Use = instead of := to assign to the existing variable.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.