🚨 fix(estimate): Rename vars and improve leggy set estimate display#1969
🚨 fix(estimate): Rename vars and improve leggy set estimate display#1969
Conversation
There was a problem hiding this comment.
Pull request overview
This PR renames terminology from "legendary" to "leggy" (consistent with the existing "Leggacy" naming in the codebase) and improves the display formatting for the leggy set estimate output. The changes update user-facing command options, internal variable names, and the output format.
Key changes:
- Renamed command option from "include-legendary" to "include-leggy"
- Renamed variables from
includeLegendarytoincludeLeggySetand parameterincludeMaximumtoincludeLeggySetfor consistency - Updated display format from
w/CS **%d**toCS:**%d**for more compact output
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| if str == "" { | ||
| str := getContractEstimateString(contractID, includeLegendary) | ||
| str := getContractEstimateString(contractID, includeLeggySet) |
There was a problem hiding this comment.
Variable shadowing bug: This line declares a new local variable 'str' using ':=' which shadows the 'str' variable declared at line 52. This means the function call result is assigned to a new local variable that goes out of scope immediately, and the original 'str' variable remains empty. This would cause the response at line 83 to always use an empty string. Remove the ':' to use assignment '=' instead of short declaration ':='.
| str := getContractEstimateString(contractID, includeLeggySet) | |
| str = getContractEstimateString(contractID, includeLeggySet) |
No description provided.