Skip to content

🚨 fix(estimate): Rename vars and improve leggy set estimate display#1969

Merged
mkmccarty merged 1 commit intomainfrom
mm-branch-3
Dec 22, 2025
Merged

🚨 fix(estimate): Rename vars and improve leggy set estimate display#1969
mkmccarty merged 1 commit intomainfrom
mm-branch-3

Conversation

@mkmccarty
Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings December 22, 2025 19:58
@mkmccarty mkmccarty merged commit 5de7ab7 into main Dec 22, 2025
16 checks passed
@mkmccarty mkmccarty deleted the mm-branch-3 branch December 22, 2025 19:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames terminology from "legendary" to "leggy" (consistent with the existing "Leggacy" naming in the codebase) and improves the display formatting for the leggy set estimate output. The changes update user-facing command options, internal variable names, and the output format.

Key changes:

  • Renamed command option from "include-legendary" to "include-leggy"
  • Renamed variables from includeLegendary to includeLeggySet and parameter includeMaximum to includeLeggySet for consistency
  • Updated display format from w/CS **%d** to CS:**%d** for more compact output

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

}
if str == "" {
str := getContractEstimateString(contractID, includeLegendary)
str := getContractEstimateString(contractID, includeLeggySet)
Copy link

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable shadowing bug: This line declares a new local variable 'str' using ':=' which shadows the 'str' variable declared at line 52. This means the function call result is assigned to a new local variable that goes out of scope immediately, and the original 'str' variable remains empty. This would cause the response at line 83 to always use an empty string. Remove the ':' to use assignment '=' instead of short declaration ':='.

Suggested change
str := getContractEstimateString(contractID, includeLeggySet)
str = getContractEstimateString(contractID, includeLeggySet)

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants