🔧 fix: Remove conditional seasonal scoring logic#1970
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request simplifies the seasonal scoring logic by removing a conditional check that applied "nerfed" scoring only to specific seasons (fall_2025 and 2026+), and instead applies the nerfed scoring unconditionally to all contracts.
Key changes:
- Removes the season-based conditional logic for determining SeasonalScoring
- Sets all contracts to use
SeasonalScoringNerfedunconditionally - Attempts to remove the "strings" package import (which is still needed elsewhere)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -6,7 +6,6 @@ import ( | |||
| "log" | |||
| "math" | |||
| "os" | |||
There was a problem hiding this comment.
The "strings" package import cannot be removed because it is still used on line 265 (strings.Builder). Removing this import will cause a compilation error.
| "os" | |
| "os" | |
| "strings" |
| /* | ||
| if c.SeasonID == "fall_2025" || strings.Contains(c.SeasonID, "2026") { | ||
| c.SeasonalScoring = ei.SeasonalScoringNerfed | ||
| } | ||
| */ |
There was a problem hiding this comment.
Instead of commenting out the conditional logic, it should be removed entirely. Commented-out code (dead code) reduces code maintainability and can be confusing to future developers. The version control system preserves the history if the code needs to be referenced later.
| /* | |
| if c.SeasonID == "fall_2025" || strings.Contains(c.SeasonID, "2026") { | |
| c.SeasonalScoring = ei.SeasonalScoringNerfed | |
| } | |
| */ |
No description provided.