🚨 fix: Remove clown emoji comment from replay output#1978
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes an explanatory comment about the clown emoji indicator from the replay output footer. The change aims to clean up user-facing messages by removing a potentially unprofessional emoji reference from the documentation.
- Removes the line explaining that "🤡 indicates alt-parade needed to hit CR target"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } else if contractIDParam != "" { | ||
| builder.WriteString("-# [brackets] indicate area for improvement.\n") | ||
| builder.WriteString("-# 🤡 indicates alt-parade needed to hit CR target.\n") | ||
| builder.WriteString("-# Teamwork scoring artifacts shown after the value..\n") |
There was a problem hiding this comment.
There's a typo in this line: "artifacts shown after the value.." has two periods instead of one at the end.
| builder.WriteString("-# Teamwork scoring artifacts shown after the value..\n") | |
| builder.WriteString("-# Teamwork scoring artifacts shown after the value.\n") |
| @@ -474,7 +474,6 @@ func printArchivedContracts(userID string, archive []*ei.LocalContract, percent | |||
| builder.WriteString("No contracts met this condition.\n") | |||
| } else if contractIDParam != "" { | |||
| builder.WriteString("-# [brackets] indicate area for improvement.\n") | |||
There was a problem hiding this comment.
The clown emoji (🤡) is still being used in the actual output on line 410 when ChickenRuns exceeds MaxCoopSize-1, but the comment explaining what it indicates has been removed. Users will see the emoji without understanding what it means. Consider either removing the emoji from line 410 as well, or keeping the explanatory comment.
No description provided.