feat(signups): Update templates for the new scoring formula#1982
feat(signups): Update templates for the new scoring formula#1982mkmccarty merged 2 commits intomkmccarty:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates signup and prediction templates to align with a new scoring formula. The changes primarily involve replacing hardcoded emojis with icon variables, updating template text, and removing the parade alts calculation from contract displays.
- Updates PE Legacy signup template to use icon variables and revises contract selection prompts
- Removes parade alts calculation and display from contract output formatting
- Standardizes footer text capitalization and adds icon variables for better consistency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| content := fmt.Sprintf( | ||
| `## 🟢🟪 PE Leggacies Sign-up: %s 🟢🟪 ## | ||
| `## :egg_prophecy: PE Leggacies Sign-up: %s :Ultra: ## |
There was a problem hiding this comment.
The emoji/icon representation is inconsistent. The first occurrence uses ':egg_prophecy:' while the second uses ':Ultra:' (with capital U). For consistency and proper rendering, both should use the same casing convention as defined in the icon variables later in the file.
|
|
||
| content := fmt.Sprintf( | ||
| `## 🟢🟪 PE Leggacies Sign-up: %s 🟢🟪 ## | ||
| `## :egg_prophecy: PE Leggacies Sign-up: %s :Ultra: ## |
There was a problem hiding this comment.
Spelling error: "Leggacies" should be "Legacies". The word "legacy" is misspelled throughout this template string.
| content := fmt.Sprintf( | ||
| `## 🟢🟪 PE Leggacies Sign-up: %s 🟢🟪 ## | ||
| `## :egg_prophecy: PE Leggacies Sign-up: %s :Ultra: ## | ||
| -# PE Leggacy (Ultra or non-Ultra) that is harder to fill will be prioritized. |
There was a problem hiding this comment.
Spelling error: "Leggacy" should be "Legacy".
| writeContracts(&b, contracts, copyPaste, iconCoop, iconCR) | ||
|
|
||
| // Footer: show for copy-paste mode or when not first | ||
| // Footer |
There was a problem hiding this comment.
The comment change is misleading. The footer is still conditionally written based on the 'copyPaste || footer' condition, so describing it simply as "Footer" without noting the conditional nature is less accurate than the previous comment.
| // Footer | |
| // Footer (only written when copyPaste or footer is true) |
| // Footer | ||
| if copyPaste || footer { | ||
| b.WriteString("\n-# ") | ||
| b.WriteString("-# ") |
There was a problem hiding this comment.
The leading "\n" was removed from this line, which may cause the footer to appear immediately after the previous content without a blank line separator. This could affect the formatting/readability of the output.
| b.WriteString("-# ") | |
| b.WriteString("\n-# ") |
| :Ultra: — Ultra | ||
| 📜 — Leggacy | ||
|
|
||
| **Any additional __Co-Op Roles__ for this account? (optional) ** |
There was a problem hiding this comment.
There is an extra space before the closing "**" on this line. The space should be removed for consistent formatting.
| **Any additional __Co-Op Roles__ for this account? (optional) ** | |
| **Any additional __Co-Op Roles__ for this account? (optional)** |
| b.WriteString("-# ") | ||
| b.WriteString(iconCoop) | ||
| b.WriteString(" coop size | 🎏 parade alts | ") | ||
| b.WriteString(" Coop size | ") |
There was a problem hiding this comment.
Capitalization change from "coop size" to "Coop size" is inconsistent with the variable name 'iconCoop'. Consider using "Co-op size" or keeping it lowercase for consistency with typical usage.
| b.WriteString(" Coop size | ") | |
| b.WriteString(" Co-op size | ") |
| if showNonUltra && len(peContracts) != 0 { | ||
| b.WriteString("**") | ||
| b.WriteString(iconPE) | ||
| b.WriteString(" PE Leggacy**\n") |
There was a problem hiding this comment.
Spelling error: "Leggacy" should be "Legacy".
| if showUltra && len(ultraContracts) != 0 { | ||
| b.WriteString("**") | ||
| b.WriteString(iconUltra) | ||
| b.WriteString(" Ultra PE Leggacy **\n") |
There was a problem hiding this comment.
Spelling error: "Leggacy" should be "Legacy". Additionally, there is an extra space before the closing "**".
| b.WriteString(" Coop size | ") | ||
| b.WriteString(iconCR) | ||
| b.WriteString(" target CRs | 🌼Seasonal LB\n") | ||
| b.WriteString(" Target CRs | 🌼Seasonal LB\n") |
There was a problem hiding this comment.
Capitalization change from "target CRs" to "Target CRs" should be consistent with the capitalization used for "Coop size" on the previous line.
| b.WriteString(" Target CRs | 🌼Seasonal LB\n") | |
| b.WriteString(" target CRs | 🌼Seasonal LB\n") |
No description provided.