🔧 Simplify replay logging by removing dev bot conditional logic#1993
🔧 Simplify replay logging by removing dev bot conditional logic#1993
Conversation
There was a problem hiding this comment.
Pull request overview
This PR simplifies replay logging by removing the conditional logic that differentiated between dev bot and production bot behavior when displaying contract estimates. The change consolidates the code to always use maximum duration and CXP estimates.
- Removed
config.IsDevBot()conditional check in replay logging - Now consistently uses
EstimatedDurationMaxandCxpMaxfor all environments
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| fmt.Fprintf(&builder, "**Duration:** %s **Est. Duration:** %s\n", bottools.FmtDuration(time.Duration(evaluation.GetCompletionTime()*float64(time.Second))), bottools.FmtDuration(c.EstimatedDurationMax)) | ||
| fmt.Fprintf(&builder, "**CS:** %d **Est CS:** %.0f (SR estimation)\n", uint32(evaluationCxp), c.CxpMax) |
There was a problem hiding this comment.
This change modifies the behavior for production environments. Previously, the production bot used EstimatedDuration and Cxp values while the dev bot used EstimatedDurationMax and CxpMax. Now both environments will use the "Max" values. This means production users will see maximum/speedrun estimates instead of standard estimates, which may not be the intended behavior. Consider whether this is the desired change or if the production bot should continue using the standard estimates.
| fmt.Fprintf(&builder, "**Duration:** %s **Est. Duration:** %s\n", bottools.FmtDuration(time.Duration(evaluation.GetCompletionTime()*float64(time.Second))), bottools.FmtDuration(c.EstimatedDurationMax)) | |
| fmt.Fprintf(&builder, "**CS:** %d **Est CS:** %.0f (SR estimation)\n", uint32(evaluationCxp), c.CxpMax) | |
| fmt.Fprintf(&builder, "**Duration:** %s **Est. Duration:** %s\n", bottools.FmtDuration(time.Duration(evaluation.GetCompletionTime()*float64(time.Second))), bottools.FmtDuration(c.EstimatedDuration)) | |
| fmt.Fprintf(&builder, "**CS:** %d **Est CS:** %.0f\n", uint32(evaluationCxp), c.Cxp) |
• Simplified replay logging by removing conditional logic for dev bot
• Streamlined logging process to make code more straightforward and maintainable