Skip to content

🔧 Simplify replay logging by removing dev bot conditional logic#1993

Merged
mkmccarty merged 1 commit intomainfrom
mm-branch-1
Dec 28, 2025
Merged

🔧 Simplify replay logging by removing dev bot conditional logic#1993
mkmccarty merged 1 commit intomainfrom
mm-branch-1

Conversation

@mkmccarty
Copy link
Copy Markdown
Owner

• Simplified replay logging by removing conditional logic for dev bot
• Streamlined logging process to make code more straightforward and maintainable

Copilot AI review requested due to automatic review settings December 28, 2025 05:06
@mkmccarty mkmccarty merged commit 1e525d3 into main Dec 28, 2025
14 checks passed
@mkmccarty mkmccarty deleted the mm-branch-1 branch December 28, 2025 05:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies replay logging by removing the conditional logic that differentiated between dev bot and production bot behavior when displaying contract estimates. The change consolidates the code to always use maximum duration and CXP estimates.

  • Removed config.IsDevBot() conditional check in replay logging
  • Now consistently uses EstimatedDurationMax and CxpMax for all environments

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/boost/replay.go
Comment on lines +439 to +440
fmt.Fprintf(&builder, "**Duration:** %s **Est. Duration:** %s\n", bottools.FmtDuration(time.Duration(evaluation.GetCompletionTime()*float64(time.Second))), bottools.FmtDuration(c.EstimatedDurationMax))
fmt.Fprintf(&builder, "**CS:** %d **Est CS:** %.0f (SR estimation)\n", uint32(evaluationCxp), c.CxpMax)
Copy link

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change modifies the behavior for production environments. Previously, the production bot used EstimatedDuration and Cxp values while the dev bot used EstimatedDurationMax and CxpMax. Now both environments will use the "Max" values. This means production users will see maximum/speedrun estimates instead of standard estimates, which may not be the intended behavior. Consider whether this is the desired change or if the production bot should continue using the standard estimates.

Suggested change
fmt.Fprintf(&builder, "**Duration:** %s **Est. Duration:** %s\n", bottools.FmtDuration(time.Duration(evaluation.GetCompletionTime()*float64(time.Second))), bottools.FmtDuration(c.EstimatedDurationMax))
fmt.Fprintf(&builder, "**CS:** %d **Est CS:** %.0f (SR estimation)\n", uint32(evaluationCxp), c.CxpMax)
fmt.Fprintf(&builder, "**Duration:** %s **Est. Duration:** %s\n", bottools.FmtDuration(time.Duration(evaluation.GetCompletionTime()*float64(time.Second))), bottools.FmtDuration(c.EstimatedDuration))
fmt.Fprintf(&builder, "**CS:** %d **Est CS:** %.0f\n", uint32(evaluationCxp), c.Cxp)

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants