Skip to content

[WIP] Update concurrent contract save queue implementation based on feedback#2136

Merged
mkmccarty merged 2 commits intomm-branch-1from
copilot/sub-pr-2131-one-more-time
Jan 30, 2026
Merged

[WIP] Update concurrent contract save queue implementation based on feedback#2136
mkmccarty merged 2 commits intomm-branch-1from
copilot/sub-pr-2131-one-more-time

Conversation

Copy link
Contributor

Copilot AI commented Jan 30, 2026

  • Add context and WaitGroup for graceful shutdown of save queue worker
  • Modify startSaveQueueWorker to accept context and use WaitGroup
  • Add ShutdownSaveQueue function to drain pending saves and wait for completion
  • Update SaveAllData to call ShutdownSaveQueue for proper shutdown
  • Test the implementation to ensure saves complete before shutdown
  • Run code review and address any feedback

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@mkmccarty mkmccarty marked this pull request as ready for review January 30, 2026 01:57
Copilot AI review requested due to automatic review settings January 30, 2026 01:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mkmccarty mkmccarty merged commit 65a8416 into mm-branch-1 Jan 30, 2026
11 of 12 checks passed
@mkmccarty mkmccarty deleted the copilot/sub-pr-2131-one-more-time branch January 30, 2026 01:57
Copilot AI requested a review from mkmccarty January 30, 2026 01:58
Copilot stopped work on behalf of mkmccarty due to an error January 30, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants