✨ feat(leaderboard): acknowledge interaction updates to avoid timeouts#2326
Merged
✨ feat(leaderboard): acknowledge interaction updates to avoid timeouts#2326
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the leaderboard component-interaction handling to defer/acknowledge only the interactions that mutate the existing leaderboard message, reducing the chance of Discord interaction timeouts.
Changes:
- Move interaction acknowledgement out of the top-level handler and into specific cases (
close,refresh,season). - Add permission checks for
refresh/seasonbefore proceeding with leaderboard updates. - Improve per-action error log messages for interaction responses.
Comments suppressed due to low confidence (1)
src/boost/leaderboard.go:114
HandleLeaderboardPagenow returns early whenCustomIDis malformed (len(parts) < 2) without sending any interaction response. That will cause Discord to show “This interaction failed” (timeout) for those cases. Consider acknowledging even on invalid/unknownCustomID(e.g., defer message update or send an ephemeral error) and/or add adefaultbranch in the switch to always respond.
parts := strings.Split(i.MessageComponentData().CustomID, "#")
if len(parts) < 2 {
return
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+121
to
+128
| // Acknowledge update interactions that mutate the existing leaderboard message. | ||
| err := s.InteractionRespond(i.Interaction, &discordgo.InteractionResponse{ | ||
| Type: discordgo.InteractionResponseDeferredMessageUpdate, | ||
| Data: &discordgo.InteractionResponseData{ | ||
| Flags: flags, | ||
| Components: []discordgo.MessageComponent{}, | ||
| }, | ||
| }) |
There was a problem hiding this comment.
The same InteractionRespond(...DeferredMessageUpdate...) acknowledgement block is duplicated across close, refresh, and season. To reduce drift (e.g., flags/components/log messages getting out of sync), consider extracting this into a small helper (or at least a local function) used by each case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.