Reduce n_samples in dataset generation tests to speed up test run#55
Merged
Reduce n_samples in dataset generation tests to speed up test run#55
Conversation
Agent-Logs-Url: https://github.com/mkofler96/DeepSDFStruct/sessions/5e14b892-9e06-46e8-ae33-e32ebf5588b5 Co-authored-by: mkofler96 <18218171+mkofler96@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
mkofler96
April 21, 2026 11:37
View session
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Python |  |
Apr 21, 2026 11:37a.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_generate_dataset.pywas taking excessively long due to the defaultn_samples=100_000being used in allprocess_geometriescalls. With 20 augmented chair meshes + 2 parametrize runs of the microstructure test, this amounted to millions of SDF queries per test run.Changes
n_samples=1000explicitly in bothtest_generate_dataset_from_obj_filesandtest_generate_dataset, reducing per-file query count from ~200k to ~2k (100× reduction).