Use crossterm explicit and remove default backends ncurses and pancurses
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Pancurses` and `Ncurses` (default features) are only used if crossterm fails. As this is very unlikely, because crossterm support all unix terminals and windows terminals down to win7, I deactivated these default features. As a result the user don't have to install the ncurses library on the system first, to be able to build the commit-tool.
This is essential so cursive uses only the crossterm backend and ignores the `pancurses` and `ncurses` backend. These backends are unsave or require additional librarys to be installed.
mkqavi
approved these changes
Jul 15, 2021
Owner
mkqavi
left a comment
mkqavi
left a comment
There was a problem hiding this comment.
Great! That's what I actually wanted to use from the beginning (that's why the crossterm-backend feature was already there) but apparently didn't 😅
Thank you for correcting this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the
crossterm-backendenabled the tool will always try to use this in favor ofncursesandpancurses(docu).However, even if
ncursesandpancursesare not in use, the user have to install the ncurses library on the system first, to build the commit tool. So to flatten the dependencies I removed the default backends and call instead explicitly the crossterm backend.As crossterm has a wider terminal support (all UNIX-Systems and Windows down to 7) as
ncursesandpancursesthis should not affect the user. Furthermore the ncurses library is known as "terribly unsafe".