fix: add release-assets.githubusercontent.com to net allowlist#13
Merged
fix: add release-assets.githubusercontent.com to net allowlist#13
Conversation
specflow self-update was prompting the end user for net access on every release because Deno's compile-time --allow-net allowlist scopes which hostnames the binary may reach, and release-assets.githubusercontent.com (the actual download host after github.com 302-redirects) was missing. A compiled binary should never prompt — that defeats one-shot self-update and breaks any non-interactive context (CI, scripted upgrade, fresh install). Adding the redirect target to the allowlist closes the gap. Note: users on v0.6.1 → 0.7.1 still see the prompt once when they self-update to the fixed version (their old binary's permissions are immutable). After they're on the fixed version, future self-updates run silently. Closes #12. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
specflow self-updatewas prompting the end user for net access on every release because Deno's compile-time--allow-netallowlist inscripts/build.tswas missingrelease-assets.githubusercontent.com— the hostgithub.com302-redirects release-asset downloads to.objects.githubusercontent.comandcodeload.github.comas belt-and-braces for any historical or future redirect path.Closes #12.
Test plan
curl -I -L—github.com/mkrlabs/specflow/releases/download/...302s torelease-assets.githubusercontent.com/...then 200s.deno task test— 318 tests pass.specflow self-update --checkfrom a v0.7.1 binary → expect the prompt once (one-time migration), then on a v0.7.2 binary → expect silent operation.🤖 Generated with Claude Code