Time and Energy Reporting with Profile Generation#164
Closed
DdIiVvYyAaMm wants to merge 1 commit intoml-energy:masterfrom
Closed
Time and Energy Reporting with Profile Generation#164DdIiVvYyAaMm wants to merge 1 commit intoml-energy:masterfrom
DdIiVvYyAaMm wants to merge 1 commit intoml-energy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#Draft PR!
No tests done. Just for overall code feedback.
Adding Timing and Energy Reporting to Endpoints with also profile Csv generation
In optimizer, we had discussed to append some energies and then send. My approach right now is:
a. To aggregate in the generate_profile_csv function, hence not appending or collecting in optimizer.py
b. Please let me know if that should be changed