Starcoder2: Update config and change GQA to use repeat#520
Merged
awni merged 3 commits intoml-explore:mainfrom Mar 3, 2024
Blaizzy:pc/starcoder2config
Merged
Starcoder2: Update config and change GQA to use repeat#520awni merged 3 commits intoml-explore:mainfrom Blaizzy:pc/starcoder2config
awni merged 3 commits intoml-explore:mainfrom
Blaizzy:pc/starcoder2config
Conversation
Contributor
Author
|
@mzbac let me know if there are any further changes needed. |
Contributor
|
Looks good to me. Let's see if @awni could help review and approve it :) |
Contributor
Author
|
Awesome! |
devonthomas35
pushed a commit
to devonthomas35/mlx-examples
that referenced
this pull request
Mar 11, 2024
* update config * change gqa to use repeat instead of concante * contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the config to match the HF Starcoder config and changes GQA to use repeat instead of concatenate as suggested here #443.
@mzbac the PR is ready!
#502 (comment)