Skip to content

Update gemm block offset adjustment to be in size_t#1087

Merged
jagrit06 merged 1 commit into
mainfrom
mm-overflow-bug-fix
May 8, 2024
Merged

Update gemm block offset adjustment to be in size_t#1087
jagrit06 merged 1 commit into
mainfrom
mm-overflow-bug-fix

Conversation

@jagrit06
Copy link
Copy Markdown
Member

@jagrit06 jagrit06 commented May 7, 2024

Proposed changes

fixes #1084

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

@jagrit06 jagrit06 requested a review from awni May 7, 2024 15:42
Copy link
Copy Markdown
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!!

@jagrit06 jagrit06 merged commit fe96cee into main May 8, 2024
@jagrit06 jagrit06 deleted the mm-overflow-bug-fix branch May 8, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Bad result for GPU matmul for specific shape

2 participants