Skip to content

Conversation

@ngoldbaum
Copy link
Contributor

Proposed changes

Fixes #2895.

The current pin is about a year old. Assuming the CI passes it seems prudent to me to update it.

NB_TYPING_TUPLE is not necessary on Python 3.9 and newer.

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

@ngoldbaum ngoldbaum mentioned this pull request Dec 10, 2025
@awni
Copy link
Member

awni commented Dec 10, 2025

@awni
Copy link
Member

awni commented Dec 10, 2025

@awni
Copy link
Member

awni commented Dec 10, 2025

And there are a few places it's hardcoded in our CI:

grep -r nanobind .github/*

@ngoldbaum
Copy link
Contributor Author

Thanks for pointing that out, I think I got them all:

goldbaum at Nathans-MBP in ~/Documents/mlx on nanobind
± grep -r "2\.4\.0"

goldbaum at Nathans-MBP in ~/Documents/mlx on nanobind
± grep -r "2\.10\.2"
./pyproject.toml:  "nanobind==2.10.2",
./setup.py:            "nanobind==2.10.2",
./examples/extensions/requirements.txt:nanobind==2.10.2
./examples/extensions/pyproject.toml:  "nanobind==2.10.2",
./.github/workflows/release.yml:          pip install cmake setuptools nanobind==2.10.2
./.github/actions/setup-linux/action.yml:        pip install setuptools cmake nanobind==2.10.2
./.github/actions/build-macos/action.yml:        pip install cmake setuptools nanobind==2.10.2

@ngoldbaum
Copy link
Contributor Author

Building on the GIL-enabled build I also see:

 /Users/goldbaum/Documents/mlx-gil/python/src/mlx_func.cpp:92:62: error: use of undeclared identifier 'NB_HAVE_VECTORCALL'
     92 |     /* .flags = */ Py_TPFLAGS_DEFAULT | Py_TPFLAGS_HAVE_GC | NB_HAVE_VECTORCALL,
        |                                                              ^

So I'll have to fix that one too.

Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! Will merge after tests clear.

@awni
Copy link
Member

awni commented Dec 10, 2025

Actually looks like the lint checks failed. Can you run the pre-commit hooks?

@ngoldbaum
Copy link
Contributor Author

Thanks for bearing with me. I might turn actions on for my fork so I can at least run the tests without pinging you.

Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@awni awni merged commit e1fee00 into ml-explore:main Dec 11, 2025
12 checks passed
@zcbenz zcbenz mentioned this pull request Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update nanobind pin

2 participants