-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Update nanobind pin to most recent version #2896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
And there are a few places it's hardcoded in our CI: |
|
Thanks for pointing that out, I think I got them all: |
|
Building on the GIL-enabled build I also see: So I'll have to fix that one too. |
awni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! Will merge after tests clear.
|
Actually looks like the lint checks failed. Can you run the pre-commit hooks? |
|
Thanks for bearing with me. I might turn actions on for my fork so I can at least run the tests without pinging you. |
awni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
Proposed changes
Fixes #2895.
The current pin is about a year old. Assuming the CI passes it seems prudent to me to update it.
NB_TYPING_TUPLEis not necessary on Python 3.9 and newer.Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes