Merged
Conversation
yaronsumel
reviewed
Dec 22, 2025
| continue | ||
|
|
||
| ip = run( | ||
| ["ssh", h.ssh_hostname, "ipconfig", "getifaddr", "en1"], |
There was a problem hiding this comment.
in my case im using ethernet->usbc adapter en1 will return nothing. I wonder if possible to iterate over enX for first match or maybe better provide hint as flag like --enX 8
sumel@mini-1 ~ % ipconfig getifaddr en4
sumel@mini-1 ~ % ipconfig getifaddr en5
sumel@mini-1 ~ % ipconfig getifaddr en6
sumel@mini-1 ~ % ipconfig getifaddr en7
sumel@mini-1 ~ % ipconfig getifaddr en8
192.168.1.101
Member
Author
There was a problem hiding this comment.
Interesting I will think about adding a flag. The config is due for a refactor to simplify it further. However, at that point it is trivial to also edit the config manually since you only need the ip of rank 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2944.
In particular:
log_warningthat was forgottenen1ifen0is not connected.