Fix float64 dtype loaded as complex64 from .npy files #2965
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dtype_from_array_protocol() function was missing a handler for float64 (size == 8) in the 'f' case, causing it to fall through to the 'c' case and return complex64 instead. Fixes ml-explore#2958
Anri-Lombard
force-pushed
the
fix/load-float64-dtype
branch
from
2e3e1f1 to
b23469f
Compare
Member
|
Thanks for the contribution. We already have a fix out for that here: https://github.com/ml-explore/mlx/pull/2960/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
dtype_from_array_protocol()to handle float64 (size == 8)Test plan
float64to the dtypes test list intest_load.pytest_load_float64_dtypefor issue [BUG]mx.loadmisinterprets dtype ascomplex64instead offloat64#2958Fixes #2958