Skip to content

Comments

fix array allocator with user buffer and deleter#2971

Merged
andresy merged 1 commit intomainfrom
managed-alloc-fix
Jan 7, 2026
Merged

fix array allocator with user buffer and deleter#2971
andresy merged 1 commit intomainfrom
managed-alloc-fix

Conversation

@andresy
Copy link
Member

@andresy andresy commented Jan 7, 2026

Proposed changes

The array allocator with a custom user buffer and deleter is inaccurately providing the Buffer pointer to the user deleter, instead of the original user pointer.

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

@andresy andresy requested review from angeloskath and awni January 7, 2026 17:34
Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@andresy andresy merged commit 1596839 into main Jan 7, 2026
15 checks passed
@andresy andresy deleted the managed-alloc-fix branch January 7, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants