Fix ALiBi slopes for non-power-of-2 num_heads#3071
Merged
awni merged 2 commits intoml-explore:mainfrom Jan 29, 2026
Merged
Conversation
Contributor
Author
|
solves ##343 |
Contributor
Author
|
cc: @zcbenz |
awni
reviewed
Jan 28, 2026
Contributor
Author
|
yay |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
What the diff addresses
The old create_alibi_slope function used a simple formula: x = (2**8) ** (1 / num_heads). The output was mx.power(x, -mx.arange(1, num_heads + 1)). This formula generated a uniform geometric sequence of slopes, which was only accurate when num_heads was a power of 2 (e.g., 1, 2, 4, 8, 16…). However, for non-power-of-2 heads (e.g., 3, 5, 6, 7, 12), it produced incorrect slopes.
The new code employs the algorithm from the https://github.com/ofirpress/attention_with_linear_biases. This algorithm handles non-power-of-2 heads by:
Additionally, the diff:
Checklist
pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes