Skip to content

Update nanobind version to v2.12.0#3396

Merged
angeloskath merged 3 commits intoml-explore:mainfrom
jrp2014:patch-1
Apr 15, 2026
Merged

Update nanobind version to v2.12.0#3396
angeloskath merged 3 commits intoml-explore:mainfrom
jrp2014:patch-1

Conversation

@jrp2014
Copy link
Copy Markdown
Contributor

@jrp2014 jrp2014 commented Apr 11, 2026

Proposed changes

See #3392 Some of the examples pull in nanobind 2.10.2. Not sure whether they should be changed to lower bound constraints or pinned, as they currently are, like here.

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

Copy link
Copy Markdown
Collaborator

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Having the examples using the pinned version is usually the safe choice.

@jrp2014
Copy link
Copy Markdown
Contributor Author

jrp2014 commented Apr 14, 2026

Ok. Ready to merge ... @zcbenz I don't think that I have permission to merge.

@angeloskath angeloskath merged commit 1fa764f into ml-explore:main Apr 15, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants