Skip to content

Fix flaky TestVmap.test_vmap_masked_scatter #3421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zcbenz merged 1 commit into from
Apr 20, 2026
+4 −4
Merged

Fix flaky TestVmap.test_vmap_masked_scatter #3421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mlx/backend/cuda/indexing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ void MaskedScatter::eval_gpu(const std::vector<array>& inputs, array& out) {
}

array mask_flat = flatten_in_eval(mask, 1, -1, s);
if (mask_flat.data<void>() != mask.data<void>()) {
if (gpu_ptr<void>(mask_flat) != gpu_ptr<void>(mask)) {
encoder.add_temporary(mask_flat);
}
if (!mask_flat.flags().row_contiguous) {
Expand Down
2 changes: 1 addition & 1 deletion mlx/backend/cuda/scan.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ constexpr bool supports_scan_op() {
}

void scan_gpu_inplace(
array in,
const array& in,
array& out,
Scan::ReduceType reduce_type,
int axis,
Expand Down
2 changes: 1 addition & 1 deletion mlx/backend/gpu/scan.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
namespace mlx::core {

void scan_gpu_inplace(
array in,
const array& in,
array& out,
Scan::ReduceType reduce_type,
int axis,
Expand Down
2 changes: 1 addition & 1 deletion mlx/backend/metal/scan.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
namespace mlx::core {

void scan_gpu_inplace(
array in,
const array& in,
array& out,
Scan::ReduceType reduce_type,
int axis,
Expand Down
Loading